Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disables minor ticks by default #26310

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 19, 2023

SUMMARY

This PR follows the same standard defined by ECharts and disables minor ticks by default for ECharts charts. From a data visualization point of view, they only add visual noise/don’t facilitate reading the chart better for the majority of cases. For the specific cases where they might help with data interpretation, I added a new control that allows users to enable them. This will also help with consistency given that legacy charts also have minor ticks disabled by default.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-12-19 at 12 00 57 Screenshot 2023-12-19 at 12 00 35

TESTING INSTRUCTIONS

1 - Create a timeseries chart
2 - Check the new control behavior
3 - Check that charts are rendered without minor ticks by default

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9111eb9) 69.18% compared to head (4597fe1) 69.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26310   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files        1945     1945           
  Lines       75967    75968    +1     
  Branches     8467     8467           
=======================================
+ Hits        52556    52557    +1     
  Misses      21224    21224           
  Partials     2187     2187           
Flag Coverage Δ
javascript 56.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Dec 19, 2023
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing to keep in mind is minor ticks will now disappear from existing charts. However, I think this is ok, as long as we're in agreement that disabled minor ticks are a more sensible default.

@michael-s-molina michael-s-molina merged commit eb65cea into apache:master Dec 20, 2023
33 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 20, 2023
michael-s-molina added a commit that referenced this pull request Dec 27, 2023
michael-s-molina added a commit that referenced this pull request Dec 27, 2023
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Jan 5, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants