Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): narrow empty drop area #26313

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

We've noticed that users are having difficulty adding an element into the tab content area because of its restricted drop zone. This commit expands the drop area for empty content to resolve the problem.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--droparea.mov

After:

after--droparea.mov

TESTING INSTRUCTIONS

Edit Dashboard and drag and drop to the new tab content

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38f5e4d) 69.18% compared to head (1ed42ac) 69.19%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26313   +/-   ##
=======================================
  Coverage   69.18%   69.19%           
=======================================
  Files        1946     1946           
  Lines       75969    75982   +13     
  Branches     8469     8468    -1     
=======================================
+ Hits        52561    52572   +11     
- Misses      21222    21223    +1     
- Partials     2186     2187    +1     
Flag Coverage Δ
javascript 56.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 19, 2023
@michael-s-molina
Copy link
Member

/testenv up

Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.221.235.129:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina
Copy link
Member

@justinpark I noticed that for some reason, I lost the ability to drag items to the dashboard. Sometimes if I refresh the dashboard, I'm able to drag them but after dropping some charts, the bug reappears. I was not able to reproduce the bug on master.

Screen.Recording.2023-12-20.at.09.31.56.mov

@justinpark justinpark force-pushed the fix--narrow-empty-content-drop-area branch from 5f120c9 to 1ed42ac Compare December 21, 2023 22:59
@justinpark
Copy link
Member Author

I noticed that for some reason, I lost the ability to drag items to the dashboard. Sometimes if I refresh the dashboard, I'm able to drag them but after dropping some charts, the bug reappears. I was not able to reproduce the bug on master.

@michael-s-molina thanks for the testing. I found the some css rule made the side effects. I just updated the hotfix for this bug.

@michael-s-molina
Copy link
Member

/testenv up

Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://52.33.238.156:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@john-bodley
Copy link
Member

ping @michael-s-molina

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit 300ddae into apache:master Jan 4, 2024
30 checks passed
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Ephemeral environment shutdown and build artifacts deleted.

@Vitor-Avila
Copy link
Contributor

This is so so so cool! Thank you so much for this improvement.

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 9, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants