Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use WEBDRIVER_OPTION_ARGS with Playwright #26315

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

Use WEBDRIVER_OPTION_ARGS with Playwright to enable overriding default Chromium flags from config file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Add a flag in WEBDRIVER_OPTION_ARGS in superset/config, verify that the change was picked up by Playwright

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (aafb54d) 69.18% compared to head (d2a7296) 69.18%.
Report is 8 commits behind head on master.

Files Patch % Lines
superset/utils/webdriver.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26315      +/-   ##
==========================================
- Coverage   69.18%   69.18%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75968    75968              
  Branches     8467     8467              
==========================================
- Hits        52557    52556       -1     
- Misses      21224    21225       +1     
  Partials     2187     2187              
Flag Coverage Δ
hive 53.67% <0.00%> (-0.01%) ⬇️
mysql 78.08% <0.00%> (-0.01%) ⬇️
postgres 78.18% <0.00%> (-0.01%) ⬇️
presto 53.62% <0.00%> (-0.01%) ⬇️
python 82.86% <0.00%> (-0.01%) ⬇️
sqlite 76.83% <0.00%> (-0.01%) ⬇️
unit 55.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgabryje kgabryje merged commit 3f9183a into apache:master Dec 20, 2023
34 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 20, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Dec 27, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 27, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants