Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplicated plugin registration #26379

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR removes the duplicated plugin registration that generates the following type of warning:

Item with key "deck_arc" already exists. You are assigning a new value.
Item with key "deck_arc" already exists. You are assigning a new value.
Item with key "big_number" already exists. You are assigning a new value.
Item with key "box_plot" already exists. You are assigning a new value.

The duplicate registration was necessary when those pages belonged to different React apps. Now, they belong to the same app which makes the registration unnecessary.

The registration should happen only once when the application initializes.

TESTING INSTRUCTIONS

1 - Open any dashboard
2 - Check that the warnings are not there anymore

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team December 29, 2023 16:47
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (863f8bb) 69.18% compared to head (dc37653) 69.14%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26379      +/-   ##
==========================================
- Coverage   69.18%   69.14%   -0.04%     
==========================================
  Files        1946     1946              
  Lines       75988    75986       -2     
  Branches     8479     8479              
==========================================
- Hits        52570    52541      -29     
- Misses      21228    21266      +38     
+ Partials     2190     2179      -11     
Flag Coverage Δ
javascript 56.46% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina merged commit 29633e7 into apache:master Dec 29, 2023
30 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 3, 2024
michael-s-molina added a commit that referenced this pull request Jan 3, 2024
michael-s-molina added a commit that referenced this pull request Jan 3, 2024
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jan 4, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants