Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ValuePercent option to LABEL TYPE for Pie and Funnel charts #26407

Merged

Conversation

kainchow
Copy link
Contributor

@kainchow kainchow commented Jan 4, 2024

SUMMARY

Add ValuePercent option to LABEL TYPE for pie and funnel charts

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image
image

TESTING INSTRUCTIONS

When the modification is complete, you can create a new Pie or Funnel chart in Superset, and select 'Value and Percentage' for the LABEL TYPE in CUSTOMIZE to validate.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kainchow for your PR. Given this is your first PR, I've kicked off the CI checks. Assuming they pass, I'll then merge your change.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f6c37e) 69.14% compared to head (1aa0efa) 69.14%.
Report is 2 commits behind head on master.

Files Patch % Lines
.../plugin-chart-echarts/src/Funnel/transformProps.ts 0.00% 1 Missing ⚠️
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26407      +/-   ##
==========================================
- Coverage   69.14%   69.14%   -0.01%     
==========================================
  Files        1946     1946              
  Lines       75990    75992       +2     
  Branches     8479     8479              
==========================================
  Hits        52544    52544              
- Misses      21267    21269       +2     
  Partials     2179     2179              
Flag Coverage Δ
javascript 56.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley merged commit 3a7d76c into apache:master Jan 4, 2024
31 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants