-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translations): Clear all #26424
fix(translations): Clear all #26424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@capping thanks for the PR. I believe you also need to update the superset/translations/zh/LC_MESSAGES/messages.json. You can read more about this here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26424 +/- ##
=======================================
Coverage 69.15% 69.15%
=======================================
Files 1947 1947
Lines 76010 76010
Branches 8481 8481
=======================================
Hits 52565 52565
Misses 21264 21264
Partials 2181 2181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 4c2e818)
(cherry picked from commit 4c2e818)
(cherry picked from commit 4c2e818)
fix(translations): Clear all
BEFORE
`
#: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx:152
msgid "Clear all"
msgstr "清楚所有"
#: superset-frontend/src/components/Table/index.tsx:210
#, fuzzy
msgid "Clear all data"
msgstr "清楚所有"
#: superset-frontend/plugins/legacy-plugin-chart-horizon/src/controlPanel.ts:86
#, fuzzy
msgid "overall"
msgstr "清楚所有"
`
AFTER
`
#: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx:152
msgid "Clear all"
msgstr "清除所有"
#: superset-frontend/src/components/Table/index.tsx:210
#, fuzzy
msgid "Clear all data"
msgstr "清除所有"
#: superset-frontend/plugins/legacy-plugin-chart-horizon/src/controlPanel.ts:86
#, fuzzy
msgid "overall"
msgstr "清除所有"
`