Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): Clear all #26424

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

capping
Copy link
Contributor

@capping capping commented Jan 8, 2024

fix(translations): Clear all

BEFORE

`
#: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx:152
msgid "Clear all"
msgstr "清楚所有"

#: superset-frontend/src/components/Table/index.tsx:210
#, fuzzy
msgid "Clear all data"
msgstr "清楚所有"

#: superset-frontend/plugins/legacy-plugin-chart-horizon/src/controlPanel.ts:86
#, fuzzy
msgid "overall"
msgstr "清楚所有"
`

AFTER

`
#: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx:152
msgid "Clear all"
msgstr "清除所有"

#: superset-frontend/src/components/Table/index.tsx:210
#, fuzzy
msgid "Clear all data"
msgstr "清除所有"

#: superset-frontend/plugins/legacy-plugin-chart-horizon/src/controlPanel.ts:86
#, fuzzy
msgid "overall"
msgstr "清除所有"
`

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley
Copy link
Member

@capping thanks for the PR. I believe you also need to update the superset/translations/zh/LC_MESSAGES/messages.json. You can read more about this here.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a7d76c) 69.15% compared to head (abbd8ba) 69.15%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26424   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files        1947     1947           
  Lines       76010    76010           
  Branches     8481     8481           
=======================================
  Hits        52565    52565           
  Misses      21264    21264           
  Partials     2181     2181           
Flag Coverage Δ
hive 53.68% <ø> (ø)
mysql 78.07% <ø> (ø)
postgres 78.17% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.85% <ø> (ø)
sqlite 76.83% <ø> (ø)
unit 55.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaoyongjie zhaoyongjie merged commit 4c2e818 into apache:master Jan 8, 2024
34 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 9, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants