Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): adding dependabot for plugins/packages and upping PR limits. #26444

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Dependabot was not configured to watch package.json files of packages and plugins. Now it is! Also upping the PR limit for the other watch jobs (default is 5 PRs, the docs say)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea4e9a6) 69.16% compared to head (1299c7f) 69.16%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26444   +/-   ##
=======================================
  Coverage   69.16%   69.16%           
=======================================
  Files        1948     1948           
  Lines       76054    76054           
  Branches     8493     8493           
=======================================
  Hits        52601    52601           
  Misses      21273    21273           
  Partials     2180     2180           
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript 56.50% <ø> (ø)
mysql 78.07% <ø> (ø)
postgres 78.17% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.85% <ø> (ø)
sqlite 77.76% <ø> (ø)
unit 55.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina
Copy link
Member

Thanks for the PR @rusackas. Could you change the interval from daily to weekly? We have some type-related bumps everyday and now that we're increasing the PR limit it may get really noisy.

@rusackas
Copy link
Member Author

Thanks for the PR @rusackas. Could you change the interval from daily to weekly? We have some type-related bumps everyday and now that we're increasing the PR limit it may get really noisy.

Done!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@rusackas rusackas merged commit b98d4b4 into master Jan 12, 2024
52 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the rise-of-the-dependabot branch April 16, 2024 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants