fix: create virtual dataset validation #26625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26625 +/- ##
=======================================
Coverage 69.16% 69.17%
=======================================
Files 1948 1948
Lines 76062 76079 +17
Branches 8493 8493
=======================================
+ Hits 52609 52626 +17
Misses 21273 21273
Partials 2180 2180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
villebro
reviewed
Jan 15, 2024
Comment on lines
592
to
593
| mock_g.user = security_manager.find_user("gamma") | ||
| mock_g2.user = mock_g.user |
There was a problem hiding this comment.
Instead of mocking, couldn't we use with override_user(user) here?
There was a problem hiding this comment.
changed, and changed all on security_tests.py also
villebro
approved these changes
Jan 16, 2024
dpgaspar
added
v3.0
michael-s-molina
added
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Jan 18, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
Jan 18, 2024
(cherry picked from commit 8e19f59)
Muhammed-baban
pushed a commit
to intellica-tech/reporting-tool
that referenced
this pull request
Jan 19, 2024
9 tasks
mistercrunch
added
🍒 3.0.4
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a validation on create virtual virtual datasets to check SQL data access
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION