-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add unique constraint to tagged_objects #26654
Changes from all commits
c5147f3
6f52978
819fa06
f28fc6e
21f29f3
9293a13
54a7981
825af01
bc361c1
023233d
6610862
6001e4e
1ee7168
a19a23f
7c4d734
62d86a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,10 @@ | |
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
import os | ||
import sys | ||
|
||
# hack to be able to import / reuse migration_utils.py in revisions | ||
module_dir = os.path.dirname(os.path.realpath(__file__)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a bit of a breakthrough, I tried before to get some sort of |
||
sys.path.append(module_dir) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
from alembic.operations import BatchOperations, Operations | ||
|
||
naming_convention = { | ||
"fk": "fk_%(table_name)s_%(column_0_name)s_%(referred_table_name)s", | ||
"uq": "uq_%(table_name)s_%(column_0_name)s", | ||
} | ||
|
||
|
||
def create_unique_constraint( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know we had some trouble in the past with some databases where we couldn't delete the constraint because the constraint name couldn't be inferred. Would it be possible to explicitly pass a constraint name here and in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remember seeing this before too, and three's also some instance of us using a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think using the |
||
op: Operations, index_id: str, table_name: str, uix_columns: list[str] | ||
) -> None: | ||
with op.batch_alter_table( | ||
table_name, naming_convention=naming_convention | ||
) as batch_op: | ||
batch_op.create_unique_constraint(index_id, uix_columns) | ||
|
||
|
||
def drop_unique_constraint(op: Operations, index_id: str, table_name: str) -> None: | ||
dialect = op.get_bind().dialect.name | ||
|
||
with op.batch_alter_table( | ||
table_name, naming_convention=naming_convention | ||
) as batch_op: | ||
if dialect == "mysql": | ||
# MySQL requires specifying the type of constraint | ||
batch_op.drop_constraint(index_id, type_="unique") | ||
else: | ||
# For other databases, a standard drop_constraint call is sufficient | ||
batch_op.drop_constraint(index_id) | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
import enum | ||
|
||
import migration_utils as utils | ||
import sqlalchemy as sa | ||
from alembic import op | ||
from sqlalchemy import Column, Enum, Integer, MetaData, Table | ||
from sqlalchemy.sql import and_, func, select | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "96164e3017c6" | ||
down_revision = "59a1450b3c10" | ||
|
||
|
||
class ObjectType(enum.Enum): | ||
# pylint: disable=invalid-name | ||
query = 1 | ||
chart = 2 | ||
dashboard = 3 | ||
dataset = 4 | ||
|
||
|
||
# Define the tagged_object table structure | ||
metadata = MetaData() | ||
tagged_object_table = Table( | ||
"tagged_object", | ||
metadata, | ||
Column("id", Integer, primary_key=True), | ||
Column("tag_id", Integer), | ||
Column("object_id", Integer), | ||
Column("object_type", Enum(ObjectType)), # Replace ObjectType with your Enum | ||
) | ||
|
||
index_id = "uix_tagged_object" | ||
table_name = "tagged_object" | ||
uix_columns = ["tag_id", "object_id", "object_type"] | ||
|
||
|
||
def upgrade(): | ||
bind = op.get_bind() # Get the database connection bind | ||
|
||
# Reflect the current database state to get existing tables | ||
metadata.reflect(bind=bind) | ||
|
||
# Delete duplicates if any | ||
min_id_subquery = ( | ||
select( | ||
[ | ||
func.min(tagged_object_table.c.id).label("min_id"), | ||
tagged_object_table.c.tag_id, | ||
tagged_object_table.c.object_id, | ||
tagged_object_table.c.object_type, | ||
] | ||
) | ||
.group_by( | ||
tagged_object_table.c.tag_id, | ||
tagged_object_table.c.object_id, | ||
tagged_object_table.c.object_type, | ||
) | ||
.alias("min_ids") | ||
) | ||
|
||
delete_query = tagged_object_table.delete().where( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a little scary, needs review, but should be ok |
||
tagged_object_table.c.id.notin_(select([min_id_subquery.c.min_id])) | ||
) | ||
|
||
bind.execute(delete_query) | ||
|
||
# Create unique constraint | ||
utils.create_unique_constraint(op, index_id, table_name, uix_columns) | ||
|
||
|
||
def downgrade(): | ||
utils.drop_unique_constraint(op, index_id, table_name) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""merging two heads | ||
|
||
Revision ID: 15a2c68a2e6b | ||
Revises: ('96164e3017c6', 'a32e0c4d8646') | ||
Create Date: 2024-01-18 12:12:52.174742 | ||
|
||
""" | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "15a2c68a2e6b" | ||
down_revision = ("96164e3017c6", "a32e0c4d8646") | ||
|
||
import sqlalchemy as sa | ||
from alembic import op | ||
|
||
|
||
def upgrade(): | ||
pass | ||
|
||
|
||
def downgrade(): | ||
pass |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""merging | ||
|
||
Revision ID: 1cf8e4344e2b | ||
Revises: ('e863403c0c50', '15a2c68a2e6b') | ||
Create Date: 2024-01-19 08:42:37.694192 | ||
|
||
""" | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "1cf8e4344e2b" | ||
down_revision = ("e863403c0c50", "15a2c68a2e6b") | ||
|
||
import sqlalchemy as sa | ||
from alembic import op | ||
|
||
|
||
def upgrade(): | ||
pass | ||
|
||
|
||
def downgrade(): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could have led to dups, if you add "hello" and "hello " it would probably trigger an error. Wasn't the root cause but might as well clean it up.