Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "build(deps): bump @mdx-js/react from 1.6.22 to 3.0.0 in /docs" #26682

Merged

Conversation

rusackas
Copy link
Member

SUMMARY

Docs builds are not working because of this bump. This should have been caught by CI on the PR, but was only caught by CI on master for some TBD reason.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (649ff4d) 69.56% compared to head (72ea332) 69.56%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26682   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files        1892     1892           
  Lines       74162    74162           
  Branches     8263     8263           
=======================================
  Hits        51592    51592           
  Misses      20489    20489           
  Partials     2081     2081           
Flag Coverage Δ
hive 53.78% <ø> (ø)
javascript 56.84% <ø> (ø)
mysql 78.23% <ø> (ø)
postgres 78.33% <ø> (ø)
presto 53.73% <ø> (ø)
python 83.21% <ø> (ø)
sqlite 77.91% <ø> (ø)
unit 56.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas changed the title Revert "build(deps): bump @mdx-js/react from 1.6.22 to 3.0.0 in /docs" fix: Revert "build(deps): bump @mdx-js/react from 1.6.22 to 3.0.0 in /docs" Jan 19, 2024
@rusackas rusackas force-pushed the revert-26547-dependabot/npm_and_yarn/docs/mdx-js/react-3.0.0 branch from 7a22598 to 72ea332 Compare January 19, 2024 18:31
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 3acda14 into master Jan 19, 2024
52 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the revert-26547-dependabot/npm_and_yarn/docs/mdx-js/react-3.0.0 branch April 16, 2024 16:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants