Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): remove unused ansi-regex #26687

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

rusackas
Copy link
Member

SUMMARY

This dependency doesn't appear to be used anywhere in the codebase.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f63e66b) 69.48% compared to head (65304b3) 69.48%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26687   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files        1892     1892           
  Lines       74107    74107           
  Branches     8254     8254           
=======================================
+ Hits        51490    51491    +1     
+ Misses      20541    20540    -1     
  Partials     2076     2076           
Flag Coverage Δ
hive 53.88% <ø> (ø)
javascript 56.85% <ø> (ø)
mysql 78.02% <ø> (-0.03%) ⬇️
postgres 78.15% <ø> (ø)
presto 53.83% <ø> (ø)
python 83.04% <ø> (+<0.01%) ⬆️
sqlite 77.73% <ø> (ø)
unit 56.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas merged commit 9c3f40d into master Jan 22, 2024
52 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the remove-ansi-regex branch April 16, 2024 16:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants