chore: silence SECRET_KEY warning when running tests #26703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26703 +/- ##
==========================================
- Coverage 69.48% 69.48% -0.01%
==========================================
Files 1894 1894
Lines 74138 74138
Branches 8243 8243
==========================================
- Hits 51515 51514 -1
- Misses 20554 20555 +1
Partials 2069 2069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mistercrunch why don't we just run the tests via cc @dpgaspar |
john-bodley
added
the
review:checkpoint
|
My main goal was to shush the warnings and it seems both ways would do this. IDK if setting |
john-bodley
removed
the
review:checkpoint
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I saw this crazy amount of warning logs about SECRET_KEY in CI logs, and thought this might silence it. Observed in another PR here -> https://github.com/apache/superset/actions/runs/7590421536/job/20676883024?pr=26698
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF