feat: auto-label PRs that contain db migrations #26745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
a team
as code owners
|
Nice. Looks like it worked. Removing the DUMMY file now, and this should be good to merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26745 +/- ##
==========================================
- Coverage 69.56% 67.27% -2.30%
==========================================
Files 1892 1892
Lines 74162 74162
Branches 8263 8263
==========================================
- Hits 51593 49894 -1699
- Misses 20488 22187 +1699
Partials 2081 2081
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR @mistercrunch. This will be really valuable when cherry-picking fixes into patch releases as we avoid PRs that contain migrations. There's a typo here label-miration-pr.yml. Could you change it to |
|
Ok, fixed the typo, should be good to merge |
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 31, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is simply to auto-assign a GitHub label
risk:db-migrationto every PR that touches that folder. Having a label we can rely on is good so it can be trusted for release automation and other purposes.I'm closing/reopening #26683 while pointing to the
apacherepo as opposed to a fork since security / perms work only on the main fork apparently.