Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Embed Modal extension override and tests #26759

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

geido
Copy link
Member

@geido geido commented Jan 23, 2024

SUMMARY

Adds an extension to override the whole Embed Modal.
Adds missing unit tests and moves the component to its own dir.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

CI should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d34874c) 69.48% compared to head (c3e94ce) 69.53%.
Report is 58 commits behind head on master.

Files Patch % Lines
...d/src/dashboard/components/EmbeddedModal/index.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26759      +/-   ##
==========================================
+ Coverage   69.48%   69.53%   +0.05%     
==========================================
  Files        1894     1894              
  Lines       74138    74655     +517     
  Branches     8243     8359     +116     
==========================================
+ Hits        51514    51913     +399     
- Misses      20555    20648      +93     
- Partials     2069     2094      +25     
Flag Coverage Δ
javascript 57.11% <75.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@michael-s-molina
Copy link
Member

Thanks for the PR and added tests @geido! I left some non-blocking comments that I think may help with readability and standardization.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 424b4c2 into master Jan 25, 2024
47 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the diego/ch77042/register-embed-modal-override branch April 16, 2024 16:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants