Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(translations): updating pot -> po -> json files (babel 2.9.1) #26773

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jan 24, 2024

SUMMARY

Runs translation scripts (e.g. pybabel) to update .pot and .po files

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e8e208d) 67.17% compared to head (8d92684) 69.50%.
Report is 1 commits behind head on master.

Files Patch % Lines
superset/views/api.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26773      +/-   ##
==========================================
+ Coverage   67.17%   69.50%   +2.32%     
==========================================
  Files        1900     1900              
  Lines       74443    74443              
  Branches     8293     8293              
==========================================
+ Hits        50009    51739    +1730     
+ Misses      22379    20649    -1730     
  Partials     2055     2055              
Flag Coverage Δ
hive 53.81% <0.00%> (?)
mysql 78.03% <0.00%> (ø)
postgres 78.13% <0.00%> (ø)
presto 53.76% <0.00%> (?)
python 83.09% <0.00%> (+4.82%) ⬆️
sqlite 77.64% <0.00%> (ø)
unit 56.48% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just a draft, but there's nothing controversial here. Feels like progress to merge this. Seems that whole flow is broken now and this fixes some of it.

@rusackas
Copy link
Member Author

Keeping this as a draft because it'll potentially overwrite a LOT of translation PRs.

@rusackas
Copy link
Member Author

We can discuss it at Town Hall and/or Release Strategy... it might warrant a SIP or some form of consensus to make doing this something that happens at each major version release (since it can undo the work of others, which seems like a breaking change)

@john-bodley john-bodley added the hold! On hold label Jan 25, 2024
@rusackas rusackas added the risk:breaking-change Issues or PRs that will introduce breaking changes label Feb 1, 2024
@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:spanish Translation related to Spanish language i18n:italian Translation related to Italian language i18n:french Translation related to French language i18n:chinese Translation related to Chinese language i18n:japanese Translation related to Japanese language i18n:russian Translation related to Russian language i18n:korean Translation related to Korean language api Related to the REST API i18n:dutch i18n:slovak i18n:portuguese i18n:brazilian labels Feb 12, 2024
@rusackas rusackas removed risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold labels Feb 12, 2024
@github-actions github-actions bot added the risk:breaking-change Issues or PRs that will introduce breaking changes label Feb 12, 2024
@rusackas rusackas removed the hold! On hold label Feb 12, 2024
@rusackas
Copy link
Member Author

Pulling in some new translation work from master and troubleshooting some files... should be current now! Also checked through some stuff with @mistercrunch and we believe that these updates should be largely non-breaking, since the pybable library seems pretty great about how it maps translation msgid fields, and our flow should not remove "obsolete" .po entries.

@rusackas rusackas marked this pull request as ready for review February 13, 2024 00:07
@rusackas
Copy link
Member Author

Just need a codeowner approval from @michael-s-molina or @villebro and we should be good to go here.

@mistercrunch
Copy link
Member

git rm superset/translations/*/*/*.json

@rusackas rusackas merged commit 91ac575 into master Feb 13, 2024
50 of 66 checks passed
@rusackas rusackas deleted the new-translations-babel-2.9.1 branch February 13, 2024 15:47
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:brazilian i18n:chinese Translation related to Chinese language i18n:dutch i18n:french Translation related to French language i18n:italian Translation related to Italian language i18n:japanese Translation related to Japanese language i18n:korean Translation related to Korean language i18n:portuguese i18n:russian Translation related to Russian language i18n:slovak i18n:spanish Translation related to Spanish language i18n:ukrainian i18n Namespace | Anything related to localization risk:breaking-change Issues or PRs that will introduce breaking changes size/XXL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants