Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): flaky json explore modal due to over-rendering #26791

Conversation

justinpark
Copy link
Member

SUMMARY

This commit reopens #26156, which resolves the issue detailed in #26276 by excluding the changes in 'QueryAutoRefresh/index.tsx' and 'reducers/sqlLab.js'.
This commit also reverses the changes introduced in #18934. Now that the issue of overrendering due to redux has been resolved, it also effectively addresses the problem outlined in issue #26755.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--overrendering.mov

After:

after--overrendering.mov

TESTING INSTRUCTIONS

Go to SQL Lab and run a query contains a json blob
Select a table in order to execute a table preview query
Click Results tab before the table preview query ends and then click the JSON column to open the JSON modal
Check the JSON modal persists while the async query status is updating

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f8c75ca) 67.19% compared to head (821a709) 67.19%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ontend/src/SqlLab/components/SouthPane/Results.tsx 71.42% 1 Missing and 3 partials ⚠️
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% 1 Missing and 1 partial ⚠️
...frontend/src/SqlLab/components/SqlEditor/index.tsx 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26791   +/-   ##
=======================================
  Coverage   67.19%   67.19%           
=======================================
  Files        1899     1900    +1     
  Lines       74368    74370    +2     
  Branches     8274     8277    +3     
=======================================
+ Hits        49969    49973    +4     
+ Misses      22344    22343    -1     
+ Partials     2055     2054    -1     
Flag Coverage Δ
javascript 56.91% <85.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinpark
Copy link
Member Author

/testenv up

Copy link
Contributor

@justinpark Container image not yet published for this PR. Please try again when build is complete.

Copy link
Contributor

@justinpark Ephemeral environment creation failed. Please check the Actions logs for details.

@michael-s-molina
Copy link
Member

/testenv up

Copy link
Contributor

@michael-s-molina Container image not yet published for this PR. Please try again when build is complete.

Copy link
Contributor

@michael-s-molina Ephemeral environment creation failed. Please check the Actions logs for details.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jan 25, 2024
@justinpark
Copy link
Member Author

cc @gaurav7261

@justinpark justinpark force-pushed the fix--sqllab-unexpected-flash-json-modal-due-to-overrender branch from 39a1846 to dbf0232 Compare January 25, 2024 18:29
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Jan 26, 2024
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid overall, well covered by tests too.

@justinpark justinpark force-pushed the fix--sqllab-unexpected-flash-json-modal-due-to-overrender branch from dbf0232 to 7e6c7bc Compare February 7, 2024 17:46
@justinpark justinpark force-pushed the fix--sqllab-unexpected-flash-json-modal-due-to-overrender branch from 7e6c7bc to 821a709 Compare February 7, 2024 17:54
@justinpark
Copy link
Member Author

/testenv up

Copy link
Contributor

github-actions bot commented Feb 9, 2024

@justinpark Ephemeral environment spinning up at http://54.245.8.160:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

@justinpark any reason not to merge this?

@rusackas rusackas merged commit 7b59c94 into apache:master Feb 14, 2024
33 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@michael-s-molina michael-s-molina added v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch and removed v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Feb 20, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants