Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): change code owners for .github #26813

Merged
merged 2 commits into from
Jan 28, 2024
Merged

chore(ci): change code owners for .github #26813

merged 2 commits into from
Jan 28, 2024

Conversation

dpgaspar
Copy link
Member

SUMMARY

Adding myself to .github, mainly because of github workflows and SECURITY.md

Also removing ephemeral env owners since it does not make sense anymore and simplifies the config

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member

@dpgaspar I was not able to see the change related to adding yourself as a .github owner. Did you forget to commit something?

@dpgaspar
Copy link
Member Author

@dpgaspar I was not able to see the change related to adding yourself as a .github owner. Did you forget to commit something?

I did... fixed now

michael-s-molina
michael-s-molina approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mistercrunch
mistercrunch approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that we could use GitHub groups here for something more dynamic if we wanted, but would have to be managed in the apache-superset org, and wouldn't be in source control. This is ok for now I think.

@rusackas rusackas merged commit e9c2fdf into apache:master Jan 28, 2024
26 checks passed
@dpgaspar dpgaspar deleted the chore/add-myself-to-ci branch January 29, 2024 11:09
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@dpgaspar @eschutho
chore(ci): change code owners for .github (apache#26813)
ca7ab84
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@dpgaspar @sfirke
chore(ci): change code owners for .github (apache#26813)
47ac2d1
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@rusackas rusackas rusackas approved these changes

@craig-rueda craig-rueda craig-rueda approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dpgaspar @michael-s-molina @mistercrunch @rusackas @craig-rueda