Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint/a11y): fixing and locking down jsx-a11y/anchor-is-valid #26820

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

There was only one violation of this rule, due to an tag that seems to have no purpose. Tag removed, and locking down the eslint rule to throw an error rather than a warning.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bc85a0) 67.22% compared to head (c6c133a) 67.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26820   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files        1895     1895           
  Lines       74211    74211           
  Branches     8245     8245           
=======================================
  Hits        49891    49891           
  Misses      22248    22248           
  Partials     2072     2072           
Flag Coverage Δ
javascript 56.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas merged commit be7c949 into master Jan 29, 2024
33 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@rusackas rusackas deleted the lock-down-jsx-a11y-anchor-is-valid branch April 16, 2024 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants