chore(CI): get docs building on ALL branches.

[rusackas]

SUMMARY

This PR does a few things:

• Splits the github action for docs in half
  • One now only runs on pushes to master... it builds and deploys docs after checking for secrets
  • One now only runs on PRs, and doesn't need secrets. It does typechecking (new step) and builds docs, and should run even on forks (e.g. dependabot bumps)
• Fixes a couple of typescript checks that were noticed by the typechecking script.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[mistercrunch]

for these yarn commands, shouldn't there be a cd docs before?

[rusackas]

I believe the working-directory parameter does that.

[mistercrunch]

I think the filenames are reversed from what they should be

[rusackas]

Oops! Names were right in the file, but the filenames themselves were wrong. Nice catch!