Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): generate FOSSA report on master, and ALWAYS check for… #26857

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

rusackas
Copy link
Member

… Apache license copy

SUMMARY

Splits the license-check action in two.

  • The FOSSA report needs credentials, so we'll just run that on push to master.
  • The apache license check should ALWAYS run... even on forks with no credentials

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from a team as a code owner January 29, 2024 20:46
@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71a950f) 67.24% compared to head (cc10175) 69.56%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26857      +/-   ##
==========================================
+ Coverage   67.24%   69.56%   +2.32%     
==========================================
  Files        1895     1895              
  Lines       74242    74248       +6     
  Branches     8252     8257       +5     
==========================================
+ Hits        49923    51653    +1730     
+ Misses      22248    20524    -1724     
  Partials     2071     2071              
Flag Coverage Δ
hive 53.81% <ø> (?)
javascript 57.01% <ø> (+<0.01%) ⬆️
mysql 77.97% <ø> (ø)
postgres 78.07% <ø> (ø)
presto 53.76% <ø> (?)
python 83.02% <ø> (+4.81%) ⬆️
sqlite 77.65% <ø> (ø)
unit 56.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 785e832 into master Jan 29, 2024
44 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@rusackas rusackas deleted the always-check-license-copy branch April 16, 2024 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:db-migration PRs that require a DB migration size/XL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants