Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(actions): run docs actions on Node 16 to conform with the project #26868

Merged
merged 2 commits into from
Jan 29, 2024
Merged

chore(actions): run docs actions on Node 16 to conform with the project #26868

merged 2 commits into from
Jan 29, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jan 29, 2024 •
edited
Loading

SUMMARY

Some dependabot PRs were passing CI because they were running on node 18 instead of 16. These installs ought to fail on node 16, but weren't. This should make things fail when they ought to.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mistercrunch
Copy link
Member

I pushed a dummy commit touching the docs/ folder to trigger that CI step

mistercrunch
mistercrunch approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving pending CI running including the docs/ build

@rusackas rusackas merged commit 5392a8c into master Jan 29, 2024
27 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@rusackas @mistercrunch @eschutho
chore(actions): run docs actions on Node 16 to conform with the proje…
cdfbef8 
…ct (apache#26868)

Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @mistercrunch @sfirke
chore(actions): run docs actions on Node 16 to conform with the proje…
65e407b 
…ct (apache#26868)

Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
@rusackas rusackas deleted the run-docs-action-on-node-16 branch April 16, 2024 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rusackas @mistercrunch