Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svg): reformatting svgs to allow license without breaking images #26901

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix(svg): reformatting svgs to allow license without breaking images #26901

merged 1 commit into from
Jan 30, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Editing a couple problematic SVG images so that they display correctly AND include the required apache license boilerplace.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes SVG icons break due to comments in them #26882
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jan 30, 2024
@rusackas rusackas merged commit 4562d38 into master Jan 30, 2024
30 checks passed
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@rusackas @eschutho
fix(svg): reformatting svgs to allow license without breaking images (a…
5d54aca 
…pache#26901)
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @sfirke
fix(svg): reformatting svgs to allow license without breaking images (a…
5b054de 
…pache#26901)
@rusackas rusackas deleted the svg-license-fix branch April 16, 2024 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG icons break due to comments in them
3 participants
@rusackas @geido @mistercrunch