Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(actions): make tech debt uploader not block CI and skip w/o creds #26966

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix(actions): make tech debt uploader not block CI and skip w/o creds #26966

merged 2 commits into from
Feb 6, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Feb 1, 2024

…

SUMMARY

The action requires the GSheet credentials and will now skip without them (e.g. on forks)
It should also not block CI if the uploader script fails

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title fix(actions): make tech debt uploader continue on error and skip w/o creds fix(actions): make tech debt uploader not block CI and skip w/o creds Feb 1, 2024
@rusackas @john-bodley
nixing main
5fb5b6d 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas rusackas merged commit 5d46d3a into master Feb 6, 2024
27 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @john-bodley @sfirke
fix(actions): make tech debt uploader not block CI and skip w/o creds (…
35ee20c 
…apache#26966)

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@rusackas rusackas deleted the make-tech-debt-uploader-safer branch April 16, 2024 16:50
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley left review comments

@geido geido geido approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rusackas @john-bodley @geido @mistercrunch