fix(ci): typo in my bash script #26987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't fin a proper way to test the `workflow_dispatch` even, even from the gh CLI, so I had to test it using other events in my branch (on:pull_request), but never tested the inside of my `if` in bash. Anyhow, was flying blind, but I think this time it should work.
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
eschutho
approved these changes
Feb 2, 2024
rusackas
approved these changes
Feb 2, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't fin a proper way to test the
workflow_dispatcheven, even from the gh CLI, so I had to test it using other events in my branch (on:pull_request), but never tested the inside of myifin bash.Anyhow, was flying blind, but I think this time it should work.
More on the intricacies of testing these workflow_dispatch workflows here: https://stackoverflow.com/questions/63362126/github-actions-how-to-run-a-workflow-created-on-a-non-master-branch-from-the-wo
Figured it out here, though I think it has to run once first on master or it won't do it...
