fix(helm): Fix inconsistency for the chart appVersion and default image tag #27005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is an inconsistency between the chart
appVersion
value and default image tag, that was introduced in PR #26923.File
Chart.yaml
declares3.1.0
as default supported version to be deployed by the chart:It's also visible by the following command:
However, the chart uses
latest
image tag that may change over time:$ helm show values superset/superset --jsonpath '{.image.tag}' latest
As far as I know, it's a good practice for Helm charts to set explicit value to
appVersion
and use it as default version to be deployed. For example, Airflow, ArgoCD and other Helm charts use this approach.The PR partially reverts PR #26923!
ADDITIONAL INFORMATION