Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Fix inconsistency for the chart appVersion and default image tag #27005

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Feb 3, 2024

SUMMARY

There is an inconsistency between the chart appVersion value and default image tag, that was introduced in PR #26923.

File Chart.yaml declares 3.1.0 as default supported version to be deployed by the chart:

...
apiVersion: v2
appVersion: "3.1.0"
description: Apache Superset is a modern, enterprise-ready business intelligence web application
name: superset
...

It's also visible by the following command:

$ helm search repo superset
NAME                    CHART VERSION   APP VERSION     DESCRIPTION
superset/superset       0.12.2          3.1.0           Apache Superset is a modern, enterprise-ready b...

However, the chart uses latest image tag that may change over time:

$ helm show values superset/superset --jsonpath '{.image.tag}'
latest

As far as I know, it's a good practice for Helm charts to set explicit value to appVersion and use it as default version to be deployed. For example, Airflow, ArgoCD and other Helm charts use this approach.
The PR partially reverts PR #26923!

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@craig-rueda craig-rueda merged commit 7a270a5 into apache:master Feb 4, 2024
28 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants