fix(plugins): Fix dashboard filter in Period Over Period KPI plugin #27013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop overriding time range comparison with dashboard filter on second query so it takes teh range from the chart - Fix percentage calculation when any of the value is 0
geido
approved these changes
Feb 5, 2024
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 5, 2024
…pache#27013) (cherry picked from commit 607301a)
|
🏷️ preset:2024.5 |
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the PoP KPI chart is rendered in a dashboard and the dashboard has a time range filter, this filter is making the chart useless because it's overriding both queries thus no comparison is happening.
Also, previously if the bigNumber or the prev Number were zero, the % change would be zero when it should have been 100%.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Error:
Screen.Recording.2024-02-05.at.13.18.09.mov
Fix:
Screen.Recording.2024-02-05.at.13.20.38.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION