Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a note about database drivers in Docker builds #27020

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

mistercrunch
Copy link
Member

See title :)

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Feb 5, 2024
Our docker images come with little to zero database driver support since
each envrionment requires different drivers, and mataining a build with
wide database support would be both challenging (dozens of databases,
python drivers, and os dependencies) and unefficient (longer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python drivers, and os dependencies) and unefficient (longer
python drivers, and os dependencies) and inefficient (longer

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a grammar nit, but otherwise seems like a warranted improvement.

@mistercrunch mistercrunch merged commit e792460 into master Feb 6, 2024
28 checks passed
@mistercrunch mistercrunch deleted the docs_docker_dbs branch February 6, 2024 02:25
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants