Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugins): Description, Category and Tags for BigNumber with Period Time Comparison plugin #27021

Merged

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

Change the description of the plugin and add category and tags to it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-02-05 at 23 18 42
Screenshot 2024-02-05 at 23 18 53

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cd7135) 67.17% compared to head (0ccc4d2) 67.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27021   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files        1899     1899           
  Lines       74354    74354           
  Branches     8266     8266           
=======================================
  Hits        49945    49945           
  Misses      22360    22360           
  Partials     2049     2049           
Flag Coverage Δ
javascript 56.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit 53daa1b into apache:master Feb 6, 2024
33 of 34 checks passed
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 12, 2024
…iod Time Comparison plugin (apache#27021)

Co-authored-by: yousoph <sophieyou12@gmail.com>
(cherry picked from commit 53daa1b)
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
…iod Time Comparison plugin (apache#27021)

Co-authored-by: yousoph <sophieyou12@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants