Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ephemeral): fix ephemeral builds in PR #27056

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(ephemeral): fix ephemeral builds in PR #27056

merged 2 commits into from
Feb 8, 2024

Conversation

mistercrunch
Copy link
Member

fixes the issue "Error response from daemon: No such image"
as observed here
https://github.com/apache/superset/actions/runs/7836111298/job/21383010014

@mistercrunch
fix(ephemeral): fix ephemeral builds in PR
97f69a4 
fixes the issue "Error response from daemon: No such image"
as observed here
https://github.com/apache/superset/actions/runs/7836111298/job/21383010014
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 8, 2024
@mistercrunch
Copy link
Member Author

/testenv up

rusackas
rusackas approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and there was much rejoicing

@mistercrunch
Copy link
Member Author

/testenv up

@mistercrunch
Copy link
Member Author

It's triggering the action defined on the default branch master, makes these events super hard to test/fix. I think moving forward the best practice it to add and handle a workflow_dispatch event, and wire the right parameters in the right place for testing. Then you can run commands like this to trigger the workflow with any param:

 gh workflow run .github/workflows/anyworkflow.yml  -r {any_branch} -f comment_body="@supersetbot unlabel noop" -f issue_number="27046"

@mistercrunch
Copy link
Member Author

I'm going to have to merge this to fix blindly, #yolo !

@mistercrunch mistercrunch merged commit 3700326 into master Feb 8, 2024
27 checks passed
@mistercrunch mistercrunch deleted the fix_ephemeral branch February 8, 2024 21:54
@mistercrunch
Copy link
Member Author

/testenv up

@mistercrunch mistercrunch mentioned this pull request Feb 8, 2024
Merged
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch @sfirke
fix(ephemeral): fix ephemeral builds in PR (apache#27056)
acc9e3a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mistercrunch @rusackas