Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(internet_port): added new ports and removed unnecessary string class #27078

Merged
merged 8 commits into from
Feb 15, 2024
Merged

chore(internet_port): added new ports and removed unnecessary string class #27078

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a50913
Update internet_port.py
anirudh-hegde Feb 11, 2024
e8de7b1
fixed line too long error
anirudh-hegde Feb 13, 2024
0aa9a8c
removed whitespaces
anirudh-hegde Feb 13, 2024
c46f36b
Merge branch 'spear' of https://github.com/anirudh-hegde/superset int…
anirudh-hegde Feb 13, 2024
5da2827
code organised
anirudh-hegde Feb 13, 2024
3ebd791
Merge branch 'apache:master' into spear
anirudh-hegde Feb 13, 2024
90efd51
Updated internet_port.py
anirudh-hegde Feb 13, 2024
3ba27e5
fixed code style
anirudh-hegde Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions superset/advanced_data_type/plugins/internet_port.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
"ldaps": [636],
"imap2": [143], # aka imap
"imaps": [993],
"MySQL": [3306],
"Remote Desktop": [3389],
"dns": [53],
"ctf": [84],
"pdap": [344]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still failing:

Suggested change
"pdap": [344]
"pdap": [344],

}


Expand Down Expand Up @@ -83,9 +88,9 @@ def port_translation_func(req: AdvancedDataTypeRequest) -> AdvancedDataTypeRespo
else port_conversion_dict[string_value]
)
except (KeyError, ValueError):
resp["error_message"] = str(
resp["error_message"] = \
f"'{string_value}' does not appear to be a port name or number"
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a newline here which the linter wants to be removed

Suggested change

break
else:
resp["display_value"] = ", ".join(
Expand Down
Loading