chore(plugins): Update dropdown control for BigNumber with Time Comparison range #27090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a description to the dropdown control - Reorder the elements in the dropdown - Rename Range to a more meaningful text
geido
approved these changes
Feb 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27090 +/- ##
=======================================
Coverage 67.17% 67.18%
=======================================
Files 1900 1900
Lines 74443 74443
Branches 8293 8293
=======================================
+ Hits 50009 50012 +3
+ Misses 22379 22376 -3
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true |
|
@yousoph Ephemeral environment spinning up at http://52.24.237.175:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 13, 2024
…rison range (apache#27090) (cherry picked from commit a912faf)
|
🏷️ preset:2024.7 |
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We are making the chart controls more usable and thus we are renaming some options and adding some information that would help users to understand the meaning of the Range for Comparison dropdown.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-02-12.at.21.48.07.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION