feat(plugins): Tooltips on BigNumber with Time Comparison chart #27092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding Tooltip to values in our chart - Add utils function that returns the comparison period - Export Tooltip component so we can use it in the chart
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #27092 +/- ##
==========================================
- Coverage 67.17% 67.17% -0.01%
==========================================
Files 1900 1900
Lines 74443 74457 +14
Branches 8293 8296 +3
==========================================
+ Hits 50009 50014 +5
- Misses 22379 22388 +9
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true |
|
@yousoph Ephemeral environment spinning up at http://52.27.72.153:8080. Credentials are |
eschutho
approved these changes
Feb 13, 2024
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷️ preset:2024.7 |
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding some tooltips on each value of the chart so there is more info to users when reading the chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
test2.mov
test1.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION