fix(helm): typo on ssl_cert_reqs variable #27094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssl_cert_reqs was missing an "s"
pcop00
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
villebro
changed the title
villebro
reviewed
Feb 12, 2024
|
Drat - forgot the version number. I’ll get that soon.
Thanks
-paul
…________________________________
From: Ville Brofeldt ***@***.***>
Sent: Monday, February 12, 2024 5:15:09 PM
To: apache/superset ***@***.***>
Cc: pcop00 ***@***.***>; Author ***@***.***>
Subject: Re: [apache/superset] fix(helm): typo on ssl_cert_reqs variable (PR #27094)
@villebro commented on this pull request.
Thanks for the fix - LGTM but please bump the version to 0.12.5
—
Reply to this email directly, view it on GitHub<#27094 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALIIE5P4OLGGR74K3JGPOBDYTKO73AVCNFSM6AAAAABDFP3OXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZWGUZTEMBWGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Cross referencing the original PR with the bug: #26663 |
|
Updated the version in the Chart.yaml and the ReadMe. Don't think that exists anywhere else. |
villebro
approved these changes
Feb 13, 2024
3 tasks
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl_cert_reqs was missing an "s"
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION