fix: try to fix cypress with magic #27098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying this because it might have worked for someone on the internets cypress-io/cypress#7204
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27098 +/- ##
==========================================
+ Coverage 67.18% 67.20% +0.02%
==========================================
Files 1900 1902 +2
Lines 74443 74514 +71
Branches 8293 8318 +25
==========================================
+ Hits 50012 50075 +63
- Misses 22376 22379 +3
- Partials 2055 2060 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mistercrunch
requested review from
jinghua-qa,
geido,
eschutho,
rusackas and
betodealmeida
as code owners
|
For the record, first try passed, trying another CI build see if we get lucky again |
geido
approved these changes
Feb 13, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress is crashing our builds on
masterI'm trying this because it might have worked for someone on the internets
cypress-io/cypress#7204