Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): *-dev tags target right stage from Dockerfile #27116

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

lodu
Copy link
Contributor

@lodu lodu commented Feb 14, 2024

Fixes this issue

SUMMARY

the Dockerfile contains a dev stage but this is not the stage that is targeted when building and releasing the *-dev tags (e.g.: master-dev on Docker Hub.
This PR fixes said behaviour, and also adds a test case for this issue.

TESTING INSTRUCTIONS

tox -- ./tests/unit_tests/scripts/docker_build.py
or
pytest ./tests/unit_tests/scripts/docker_build.py

ADDITIONAL INFORMATION

  • Has associated issue: Docker *-dev tag's are not targetting the dev stage of Dockerfile #27111
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13f1642) 67.16% compared to head (eec1fdf) 67.16%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27116   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files        1900     1900           
  Lines       74444    74444           
  Branches     8296     8296           
=======================================
  Hits        50002    50002           
  Misses      22387    22387           
  Partials     2055     2055           
Flag Coverage Δ
mysql 78.02% <ø> (ø)
postgres 78.12% <ø> (ø)
python 78.26% <ø> (ø)
sqlite 77.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas changed the title Fix(docker): *-dev tags target right stage from Dockerfile fix(docker): *-dev tags target right stage from Dockerfile Feb 14, 2024
@mistercrunch mistercrunch merged commit 9514300 into apache:master Feb 15, 2024
32 of 33 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants