Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump firebolt-sqlalchemy to support service account auth #27118

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

Firebolt recently implemented service account authentication support to their connector. This PR bumps the connector dependency requirements to support it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No UI changes.

TESTING INSTRUCTIONS

  1. Create a service account in Firebolt.
  2. Connect to Superset using the service account ID and secret.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af577d6) 67.16% compared to head (f47a49f) 67.16%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27118   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files        1900     1900           
  Lines       74447    74447           
  Branches     8297     8297           
=======================================
+ Hits        50005    50006    +1     
+ Misses      22387    22386    -1     
  Partials     2055     2055           
Flag Coverage Δ
mysql 78.00% <ø> (-0.03%) ⬇️
postgres 78.12% <ø> (ø)
python 78.26% <ø> (+<0.01%) ⬆️
sqlite 77.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch merged commit b60938b into apache:master Feb 15, 2024
33 checks passed
@mistercrunch
Copy link
Member

SoL2S2

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants