fix(plugins): Apply dashboard filters to comparison query in BigNumber with Time Comparison chart #27138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply any other filter when in dashboard except for a time range since that's computes with the ranges
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27138 +/- ##
=======================================
Coverage 67.15% 67.15%
=======================================
Files 1902 1902
Lines 74453 74453
Branches 8306 8306
=======================================
Hits 49998 49998
Misses 22401 22401
Partials 2054 2054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true |
|
@Antonio-RiveroMartnez Ephemeral environment spinning up at http://54.201.26.152:8080. Credentials are |
geido
approved these changes
Feb 16, 2024
|
Ephemeral environment shutdown and build artifacts deleted. |
grvoicu
added a commit
to grvoicu/superset
that referenced
this pull request
Feb 20, 2024
…-to-the-embedded-dashboard * master: (1182 commits) fix(ci): mypy pre-commit issues (apache#27161) feat(Alerts and Reports): Modal redesign (apache#26202) refactor: Migrate ErrorBoundary to typescript (apache#27143) chore(tests): Remove unnecessary explicit Flask-SQLAlchemy session expunges (apache#27136) fix(plugins): Apply dashboard filters to comparison query in BigNumber with Time Comparison chart (apache#27138) fix: Duplicated toast messages (apache#27135) docs: add Geotab to users list (apache#27134) fix: Plain error message when visiting a dashboard via permalink without permissions (apache#27132) fix: ID param for DELETE ssh_tunnel endpoint (apache#27130) chore(hail mary): Update package-lock.json via npm-audit-fix (apache#26693) chore: lower cryptography min version to 41.0.2 (apache#27129) docs(miscellaneous): Export Datasoruces: export datasources exports to ZIP (apache#27120) fix(pivot-table-v2): Added forgotten translation pivot table v2 (apache#22840) fix: RLS modal overflow (apache#27128) refactor: Updates some database columns to MediumText (apache#27119) fix: gevent upgrade to 23.9.1 (apache#27112) fix: removes old deprecated sqllab endpoints (apache#27117) feat(storybook): Co-habitating/Upgrading Storybooks to v7 (dependency madness ensues) (apache#26907) fix: bump grpcio, urllib3 and paramiko (apache#27124) chore(internet_port): added new ports and removed unnecessary string class (apache#27078) ...
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 20, 2024
…r with Time Comparison chart (apache#27138) (cherry picked from commit dab44c0)
|
🏷️ preset:2024.8 |
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
…r with Time Comparison chart (apache#27138)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The dashboard filters are being ignored from the comparison query in our BigNumber with Time Comparison chart. This PR is fixing that so such query can properly manage the filters while ignoring the time range filter becase it's set by the range set on the chart
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Error:
Fix:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION