Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): Missing empty query result state #27313

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(sqllab): Missing empty query result state #27313

merged 1 commit into from
Mar 1, 2024

Conversation

justinpark
Copy link
Member

Fixes #27311

SUMMARY

This commit fixes the missing empty query result placeholder.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2024-02-29 at 4 48 18 PM

After:
Screenshot 2024-02-29 at 4 43 02 PM

TESTING INSTRUCTIONS

Open a new tab in SQL Lab and check the result panel message

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Mar 1, 2024
@justinpark justinpark force-pushed the fix--sqllab-missing-default-result-pane-msg branch from 8f6e937 to 4c2d4e2 Compare March 1, 2024 00:56
@pull-request-size pull-request-size bot added size/S and removed size/L labels Mar 1, 2024
@justinpark justinpark changed the title Fix sqllab missing default result pane msg fix(sqllab): Missing empty query result state Mar 1, 2024
eschutho
eschutho approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinpark!

michael-s-molina
michael-s-molina approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit ae8ec9c into apache:master Mar 1, 2024
24 of 26 checks passed
michael-s-molina pushed a commit that referenced this pull request Mar 4, 2024
@justinpark @michael-s-molina
fix(sqllab): Missing empty query result state (#27313)
f063240 
(cherry picked from commit ae8ec9c)
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@justinpark @sfirke
fix(sqllab): Missing empty query result state (apache#27313)
a0f2500
@mistercrunch mistercrunch added 🍒 4.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Apr 17, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@justinpark @qleroy
fix(sqllab): Missing empty query result state (apache#27313)
a7c5427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.0 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Placeholder image is missing in sql lab for new tabs
4 participants
@justinpark @eschutho @michael-s-molina @mistercrunch