Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing shared color in mixed timeseries #27403

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: missing shared color in mixed timeseries #27403

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0120fde
fix: missing shared color in mixed timeseries
justinpark Mar 6, 2024
480cdc3
rearrange seriesEntry logic
justinpark Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@
rawSeriesB.forEach(entry => {
const entryName = String(entry.name || '');
const seriesName = `${inverted[entryName] || entryName} (1)`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const seriesName = `${inverted[entryName] || entryName} (1)`;
const seriesEntry = inverted[entryName] || entryName;
const seriesName = `${seriesEntry} (1)`;

const colorScaleKey = getOriginalSeries(seriesName, array);
const colorScaleSeriesName = inverted[entryName] || entryName;
const colorScaleKey = getOriginalSeries(colorScaleSeriesName, array);

Check warning on line 415 in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts

View check run for this annotation

Codecov / codecov/patch

superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts#L415 

Added line #L415 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const colorScaleSeriesName = inverted[entryName] || entryName;
const colorScaleKey = getOriginalSeries(colorScaleSeriesName, array);
const colorScaleKey = getOriginalSeries(seriesEntry, array);


const seriesFormatter = getFormatter(
customFormattersSecondary,
Expand Down
Loading