perf(sqllab): reduce bootstrap data delay by queries #27488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
requested review from
rusackas,
betodealmeida,
eschutho and
michael-s-molina
justinpark
force-pushed
the
perf--migrate-queries-from-initial-state
branch
from
cb67955
to
17be1ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27488 +/- ##
==========================================
+ Coverage 69.73% 69.74% +0.01%
==========================================
Files 1909 1910 +1
Lines 74692 74719 +27
Branches 8325 8335 +10
==========================================
+ Hits 52086 52115 +29
Misses 20556 20556
+ Partials 2050 2048 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=true |
|
@justinpark Ephemeral environment spinning up at http://35.87.7.33:8080. Credentials are |
justinpark
added
the
v4.0
michael-s-molina
removed
the
v4.0
|
Ephemeral environment shutdown and build artifacts deleted. |
deepak-kumar-007
pushed a commit
to deepak-kumar-007/superset-forked
that referenced
this pull request
Mar 18, 2024
michael-s-molina
added
the
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit f4bdcb5)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
mistercrunch
added
🍒 4.0.0
🏷️ bot
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The SQL Lab bootstrap data, which includes all queries associated with every open editor tab, is quite large in size.
This has been causing a noticeable delay in the initial loading time for SQL Lab. It's important to note that these queries are solely used for maintaining a query history, so this update is designed to bypass these queries in the bootstrap data.
Instead, we will use the Query API to fetch the same results when the Query History component loads, making the process more efficient.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
paginated-editor-queries.mov
TESTING INSTRUCTIONS
Go to SQL Lab and run some queries in a tab and then switch the query history tab
ADDITIONAL INFORMATION