Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pylint errors on master #27710

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes the following Pylint errors on master:

Run pylint -j 0 superset
************* Module superset.models.helpers
superset/models/helpers.py:39:0: E06[11](https://github.com/apache/superset/actions/runs/8451756743/
job/23150751017?pr=25353#step:5:12): No name 'escape' in module 'flask' (no-name-in-module)
superset/models/helpers.py:39:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.models.sql_lab
superset/models/sql_lab.py:28:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.tags.models
superset/tags/models.py:22:0: E0611: No name 'escape' in module 'flask' (no-name-in-module)
************* Module superset.views.database.mixins
superset/views/database/mixins.py:19:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.views.chart.mixin
superset/views/chart/mixin.py:17:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.connectors.sqla.views
superset/connectors/sqla/views.py:21:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.connectors.sqla.models
superset/connectors/sqla/models.py:36:0: E0611: No name 'escape' in module 'flask' (no-name-in-module)
superset/connectors/sqla/models.py:36:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.utils.core
superset/utils/core.py:63:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.utils.date_parser
superset/utils/date_parser.py:52:0: E1[12](https://github.com/apache/superset/actions/runs/8451756743/
job/23150751017?pr=25353#step:5:13)0: 
No value for argument 'self' in unbound method call (no-value-for-parameter)

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team March 27, 2024 16:23
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.89%. Comparing base (349e496) to head (281babf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27710      +/-   ##
==========================================
+ Coverage   69.77%   69.89%   +0.11%     
==========================================
  Files        1911     1911              
  Lines       75056    75060       +4     
  Branches     8362     8362              
==========================================
+ Hits        52374    52461      +87     
+ Misses      20630    20547      -83     
  Partials     2052     2052              
Flag Coverage Δ
hive 48.93% <100.00%> (?)
mysql 77.91% <100.00%> (+0.02%) ⬆️
postgres 78.02% <100.00%> (+<0.01%) ⬆️
presto 53.64% <100.00%> (?)
python 83.15% <100.00%> (+0.23%) ⬆️
sqlite 77.46% <100.00%> (+<0.01%) ⬆️
unit 56.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina merged commit 883e455 into apache:master Mar 27, 2024
38 of 39 checks passed
@betodealmeida
Copy link
Member

@michael-s-molina do we know what caused this to become a problem?

@john-bodley
Copy link
Member

@betodealmeida regarding your comment, the only explanation I can think of is that either for the PR which bumped pylint:

  • The relevant CI checks did not run/block*.
  • The code in master had evolved between the time the CI checks ran and the PR was merged.

* Per #27574 we had previously identified issues were certain GitHub checks weren't marked as required.

@mistercrunch
Copy link
Member

The workflow at .github/workflows/superset-python-misc.yml will only run if files in superset/** are touched. So when dependabot / supersetbot bumps a linting lib like this we should touch a file in the folder to trigger it.

EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants