Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(k8s): making it clear users MUST update secrets for prod instances. #27954

Merged
merged 2 commits into from Apr 10, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 9, 2024

SUMMARY

Addressing some confusion from this issue: #27931

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@rusackas rusackas requested a review from villebro April 9, 2024 20:42
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Apr 9, 2024
@rusackas rusackas requested review from sfirke and dpgaspar April 9, 2024 20:42
@rusackas
Copy link
Member Author

rusackas commented Apr 9, 2024

@margorczynski let me know if this addresses your concern, or make suggestions accordingly if not :) Thanks.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an alternate simplified version.

docs/docs/installation/running-on-kubernetes.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@margorczynski
Copy link

Hey @rusackas, yep, I think this more stronly suggests that the config needs to be overwritten for this to work, thank you for the update :)

@rusackas rusackas merged commit c5c5f4d into master Apr 10, 2024
29 checks passed
@rusackas rusackas deleted the secret-key-must-change-for-prod branch April 10, 2024 14:25
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
…es. (apache#27954)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
…es. (apache#27954)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
…es. (apache#27954)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants