chore: module scope should not require the app context #28378
+1,740
−1,168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
reviewed
May 8, 2024
github-actions
bot
added
doc
mistercrunch
force-pushed
the
late_config
branch
2 times, most recently
from
a09b851
to
e8b23de
Compare
github-actions
bot
added
github_actions
mistercrunch
force-pushed
the
late_config
branch
3 times, most recently
from
d3693a5
to
ea449c9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This is a major issue that's been plaguing the backend for a long time. Currently you can't simply run a simple `from superset import models` without getting an error about the app context missing.
This DRAFT PR tries to evaluate what's getting in the way. So far I've identified:
- app.config being referenced in module scope, this is mostly easy to fix for common configuration, where we can rely on flask.current_app and avoid module scope
- dynamic/configurable model: this seems to be the core issue, where say we let people configure their EncryptedField's type
- some reliance on SecurityManager, and SecurityManager.user_model used as a relationship, I think this can be worked around using sqlalchemy's `relationship("use-a-string-reference")` call
- ???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major issue that's been plaguing the backend for a long time. Currently you can't simply run a simple
from superset import models(or pretty much any other module import) without getting an error about the app context missing, and/or circular importsThis DRAFT PR tries to evaluate what's getting in the way. So far I've identified:
relationship("use-a-string-reference")callTODO:
SQLALCHEMY_ENCRYPTED_FIELD_TYPE_ADAPTERaltogether (?) unless we can find some solutionTO-LOOK-INTO