Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): restored hidden field values has discarded #29349

Merged

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Jun 24, 2024

SUMMARY

When the x-axis was changed back to a time item from a non-time control item, the values of hidden fields were not properly restored to their original state, causing them to be consistently recognized as hidden items and preventing form_data from being sent.
This commit fixes the issue and includes test code to prevent regression.

Fixes #29331

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--missing-hidden-fields.mov

After:

after--hidden-fields.mov

TESTING INSTRUCTIONS

  1. Create line chart with temporal x-axis column and COUNT(*) metric and a specific time grain like Month
  2. Switch the x-axis variable to categorical or numeric variable instead and click Update Chart
  3. Switch the x-axis variable back to the original variable.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added explore Namespace | Anything related to Explore need:tests This PR requires tests labels Jun 24, 2024
@rusackas
Copy link
Member

Thank you!!!

@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Jun 24, 2024
@justinpark justinpark force-pushed the hotfix--hidden-control-value-discarded branch from a9ad6f2 to b705009 Compare June 24, 2024 21:10
@justinpark justinpark merged commit 160cece into apache:master Jun 24, 2024
34 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 25, 2024
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Jun 25, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore Namespace | Anything related to Explore need:tests This PR requires tests size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing to non-temporal variable, then back, causes time grain to no longer function in 4.0.2rc2
4 participants