[WIP] SEC-70 - Gamma users shouldn't be able to create roles #29687
+128
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently users with gamma roles are still able to create roles when FAB_ADD_SECURITY_API = True, This PR is made to fix this security issue as well as add test. Reason why this is happening is due to the instantiation of the
ModelRestAPI
classes happening here https://github.com/dpgaspar/Flask-AppBuilder/blob/2d527aae09eed50fd52c6bf886a2970adb225428/flask_appbuilder/security/sqla/manager.py#L97To fix it I've overriding the
register_view
call in manager and moving the logic tosuperset/initialization
file. Then adding our own custom logic to only allow admin to make these requestBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
FAB_ADD_SECURITY_API = True
ADDITIONAL INFORMATION