fix(frontend/docker, ci): fix borked Docker build due to Lerna v8 uplift #29725
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
commented
Jul 27, 2024
| @@ -26,7 +26,7 @@ fi | |||
| if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then | |||
| cd /app/superset-frontend | |||
| npm install -f --no-optional --global webpack webpack-cli | |||
| npm install -f --no-optional | |||
| npm install -f | |||
There was a problem hiding this comment.
@mistercrunch I saw this flag was added previously but unsure the context. I believe there's a historical reason for it? 👀
hainenber
changed the title
|
@eschutho I'm not able to reproduce your CI issue as this PR's https://github.com/apache/superset/actions/runs/10120546422/job/27990411018?pr=29725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(frontend/docker, ci): fix borked Docker build due to Lerna v8 uplift
SUMMARY
Closes #29658
Remove
--no-optionalindocker-frontend.shto allow installing@nxoptional dependencies which is necessary for Lerna v8Also upgrading
prop-typesto next minor version to assess reproducibility of issue raised in PR #29723BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION