Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caravel dashboard filters #306

Closed
wants to merge 10 commits into from
Closed

Caravel dashboard filters #306

wants to merge 10 commits into from

Conversation

gbrian
Copy link
Contributor

@gbrian gbrian commented Apr 9, 2016

Fix for #144

clearFiltersremoved. Seems not being used by anyone. Please validate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.365% when pulling 02e111e on gbrian:caravel_dashboard_filters into 866e00d on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.365% when pulling 02e111e on gbrian:caravel_dashboard_filters into 866e00d on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 02e111e on gbrian:caravel_dashboard_filters into 866e00d on airbnb:master.

1 similar comment
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 02e111e on gbrian:caravel_dashboard_filters into 866e00d on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 72.583% when pulling 9384a5d on gbrian:caravel_dashboard_filters into c6da811 on airbnb:master.

@sid88in
Copy link
Contributor

sid88in commented May 6, 2016

@gbrian any update on this? Does this fix the multiple dynamic filter problems? Can you please rebase with master and open it for testing? I can then try locally.

Thanks

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 04f680f on gbrian:caravel_dashboard_filters into 2f64c42 on airbnb:master.

@gbrian
Copy link
Contributor Author

gbrian commented May 7, 2016

@sid88in, PR updated.

This tries to fix the issue with multiple filters about loosing filters selection.
I needed to change how filters are store due to the filter behavior present on tables graphs.
So now filters are not based on slices, just in fields. in this way you will be filtering by a field value regardless if you set a filter or click a table value.

Hope this helps.

@coveralls
Copy link

coveralls commented May 7, 2016

Coverage Status

Coverage increased (+0.03%) to 81.613% when pulling 04f680f on gbrian:caravel_dashboard_filters into 2f64c42 on airbnb:master.

@sid88in
Copy link
Contributor

sid88in commented May 7, 2016

Thanks!
I will test this in local and see if it resolves our use case with filter bug.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+0.03%) to 82.137% when pulling a520245 on gbrian:caravel_dashboard_filters into 087c47a on airbnb:master.

@mistercrunch
Copy link
Member

This got tackled somewhere else. Thanks for the PR though!

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat: Add Iran to countries

* feat: Add Iran to countries
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat: Add Iran to countries

* feat: Add Iran to countries
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat: Add Iran to countries

* feat: Add Iran to countries
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat: Add Iran to countries

* feat: Add Iran to countries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants