[Sql Lab] Remember Sql Editor window size after user switch tabs #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 69.118% when pulling 201cf703afceacc41d60bfe0e3128bc9e515c2b8 on graceguo-supercat:gg-RemeberEditorWindowHeight into 3dfdde1 on apache:master. |
|
Please rebase |
graceguo-supercat
force-pushed
the
gg-RemeberEditorWindowHeight
branch
from
201cf70
to
20e410a
Compare
1 similar comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I save Editor current height as a state attribute (Redux store "queryEditors"). And the whole redux store will be persisted into localStorage.