Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add navigation, zoom to treemap #396

Merged
merged 3 commits into from
Apr 26, 2016
Merged

add navigation, zoom to treemap #396

merged 3 commits into from
Apr 26, 2016

Conversation

andrewhn
Copy link
Contributor

This PR:

  • improves the styling of treemaps
  • adds UI options for target aspect ratio for tiles and number formats
  • adds click zoom with breadcrumbs

image

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling a17688b on andrewhn:treemap-improvements into 7d90f26 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.788% when pulling a17688b on andrewhn:treemap-improvements into 7d90f26 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.788% when pulling 0117493 on andrewhn:treemap-improvements into 7d90f26 on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 0117493 on andrewhn:treemap-improvements into 7d90f26 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.818% when pulling ebf1cbc on andrewhn:treemap-improvements into 7b10759 on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling ebf1cbc on andrewhn:treemap-improvements into 7b10759 on airbnb:master.

mistercrunch
mistercrunch reviewed Apr 26, 2016
View reviewed changes
caravel/forms.py
@@ -336,6 +337,26 @@ def __init__(self, viz):
'9/91 percentiles',
])
),
'treemap_ratio': DecimalField(
'Ratio',
default=0.5 * (1 + math.sqrt(5)), # d3 default, golden ratio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the golden ratio here :)

@mistercrunch
Copy link
Member

img

@mistercrunch mistercrunch merged commit a2f2ad8 into apache:master Apr 26, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @vx/legend from 0.0.194 to 0.0.195 (apache#396)
1efa690 
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @vx/legend from 0.0.194 to 0.0.195 (apache#396)
4244cb7 
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @vx/legend from 0.0.194 to 0.0.195 (apache#396)
1535795 
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @vx/legend from 0.0.194 to 0.0.195 (apache#396)
4739005 
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.9 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewhn @landscape-bot @coveralls @mistercrunch