resolve python2 str() issue #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Dec 8, 2017
superset/viz.py
Outdated
| @@ -1300,9 +1300,9 @@ def get_data(self, df): | |||
| for i, v in ys.iteritems(): | |||
| x = i | |||
| if isinstance(x, (tuple, list)): | |||
| x = ', '.join([str(s) for s in x]) | |||
| x = ', '.join([str(s.encode('utf8')) for s in x]) | |||
There was a problem hiding this comment.
I think you want to use six.text_type(s) instead.
There was a problem hiding this comment.
@john-bodley I tried six.text_type but it didn't work. python 2 str uses ascii encoding scheme by default so it will break unless utf-8 is specified.
There was a problem hiding this comment.
@john-bodley I removed the str(). six.text_type makes sense now.
xrmx
reviewed
Dec 8, 2017
|
@xrmx I think that's for when there are non-ascii characters in the python file and that's not the case here. |
|
LGTM |
timifasubaa
changed the title
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* make string conversion use utf8 * Update viz.py * make utf-8 consistent with other usages * Update viz.py * Update viz.py
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* make string conversion use utf8 * Update viz.py * make utf-8 consistent with other usages * Update viz.py * Update viz.py
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slices with utf8 characters are breaking during the string conversion in the lines changed. This removes the str and uses six.text_type so it stays unicode in python2 and becomes str in python3.
@john-bodley @mistercrunch